Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ACL JSON list output option #102

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Add ACL JSON list output option #102

merged 1 commit into from
Jan 10, 2024

Conversation

krockpot
Copy link
Contributor

@krockpot krockpot commented Jan 10, 2024 •
edited
Loading

Add a mechanism for writing the ACL out as a JSON list, so it can be fed into knox access -acl

This request came from an internal team.

Tested with a new build locally:

❯ bazelisk run .../knox_client -- acl -json jkrach:test:demo_key                                                                                                                                                                                                                                                                                        ...
[{"type":"User","id":"jkrach","access":"Admin"},{"type":"UserGroup","id":"security-team","access":"Admin"},...{"type":"Machine","id":"cli-testing","access":"Read"}]

@krockpot krockpot requested review from csstaub and xia0pin9 January 10, 2024 20:24
@krockpot krockpot merged commit d42b583 into master Jan 10, 2024
3 checks passed
@krockpot krockpot deleted the addACLJSON branch January 10, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devinlundberg devinlundberg devinlundberg approved these changes

@csstaub csstaub Awaiting requested review from csstaub

@xia0pin9 xia0pin9 Awaiting requested review from xia0pin9

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krockpot @devinlundberg